Add macOS support for PAC in System Preferences

carsonyl / pypac

Find and use proxy auto-config (PAC) files with Python and Requests.

https://pypac.readthedocs.io

Apache License 2.0

71 stars 19 forks source link

Add macOS support for PAC in System Preferences #23

Closed LKleinNux closed 6 years ago

LKleinNux commented 6 years ago

The PAC File in the macOS System Preferences is available through the pyobjc SystemConfiguration module.

coveralls commented 6 years ago

Coverage decreased (-2.9%) to 93.542% when pulling 256ef098901b1246d20ffca47cbf94efb5f5e4f2 on LKleinNux:feature/pac-macos-preferences into 6288121f7dad5c76411fc22dd488222955048c5b on carsonyl:master.

coveralls commented 6 years ago

Coverage decreased (-4.7%) to 91.701% when pulling c7af2631201953bd75cf346147df14f82a53b1a1 on LKleinNux:feature/pac-macos-preferences into 6288121f7dad5c76411fc22dd488222955048c5b on carsonyl:master.

carsonyl commented 6 years ago

Thanks so much! I will take a look as soon as I can.

carsonyl commented 6 years ago

Thanks again for your contribution! Good call on deprecating and replacing from_registry.

I don't normally use a Mac, so I trust these changes work for you. I've released v0.9.0 on PyPI that includes your changes.

LKleinNux commented 6 years ago

Thank you for accepting it and releasing it so fast 🙂