search

carsonyl / pypac

Find and use proxy auto-config (PAC) files with Python and Requests.
https://pypac.readthedocs.io
Apache License 2.0
71 stars 18 forks source link

Switch dukpy libraries to remove memory leaks #31

Closed maximinus closed 5 years ago

maximinus commented 5 years ago

Using pypac with amol-/dukpy as the dukpy lib leaves us on duktape 1.4 and there is a memory leak.

Switching to kovidgoyal/dukpy switches to duktape 2.0 and removes the memory leak.

Unfortunately, I could find no way of fixing the setup.py so that the new dukpy could be pulled in automatically. To install, you would need to do something like:

    # setup python virtualenv
    pip install wheel
    git clone https://github.com/kovidgoyal/dukpy.git
    cd dukpy
    python setup.py bdist_wheel
    cd dist
    pip install <wheel_file_in_folder>
    cd ../..
    git clone https://github.com/maximinus/pypac.git
    cd pypac
    python setup.py bdist_wheel
    cd dist
    pip install <wheel_file_in_folder>
carsonyl commented 5 years ago

Thanks for looking into this issue. However, this pull request is a non-starter: I can't have PyPAC depend on a library that isn't distributed on PyPI. Hopefully we can find an alternate solution.