Fix for issue #34 - dnsResolve() now always returns a string

carsonyl / pypac

Find and use proxy auto-config (PAC) files with Python and Requests.

https://pypac.readthedocs.io

Apache License 2.0

71 stars 18 forks source link

Fix for issue #34 - dnsResolve() now always returns a string #35

Closed maximinus closed 5 years ago

maximinus commented 5 years ago

Stops duktape crashing if another js function depends on the result of dnsResolve being a string.

coveralls commented 5 years ago

Coverage remained the same at 88.936% when pulling 6d80317dd5db51b8fde655f1681f9f15f5908e98 on maximinus:master into 5a4a67b52ca12ba0b4ba45e68efafe8be10be1f3 on carsonyl:master.

carsonyl commented 5 years ago

Thank you for contributing this fix. 👍

carsonyl commented 5 years ago

Fixes #34. v0.12.0 released to PyPI with this change.