carsonyl / pypac

Find and use proxy auto-config (PAC) files with Python and Requests.
https://pypac.readthedocs.io
Apache License 2.0
71 stars 19 forks source link

Quote username and password in add_proxy_auth #46

Closed aslafy-z closed 5 years ago

aslafy-z commented 5 years ago

Use urllib.quote_plus to urlencode the username and password before adding them in the proxy url.

carsonyl commented 5 years ago

Thanks for your contribution.

aslafy-z commented 5 years ago

Thanks for merging this. Could you please cut a new release? Thank you!

carsonyl commented 5 years ago

0.13.0 with this fix is now on PyPI.