search

carstenbauer / MonteCarlo.jl

Classical and quantum Monte Carlo simulations in Julia
https://carstenbauer.github.io/MonteCarlo.jl/dev/
Other
186 stars 18 forks source link

udt -> udt! #35

Closed ffreyer closed 4 years ago

ffreyer commented 4 years ago

Can we use udt! instead of udt here? https://github.com/crstnbr/MonteCarlo.jl/blob/310391725eb0607d8d40c4cc4e10217a0d19a5a2/src/flavors/DQMC/stack.jl#L242

ffreyer commented 4 years ago

Also, somewhat unrelated, the line before should probably use rmul!(mc.s.curr_U, Diagonal(mc.s.d)) and the line after mul!(mc.s.t_stack[:, :, idx + 1], T, mc.s.t_stack[:, :, idx])

carstenbauer commented 4 years ago

It should, see https://github.com/crstnbr/dqmc/blob/master/src/stack.jl#L278

ffreyer commented 4 years ago

We can also use mc.s.tmp here, instead of T

carstenbauer commented 4 years ago

We can also use mc.s.tmp here, instead of T

Shouldn't make (much of) a difference though, right? It is not going to be in-place in either case.