search

carstenbauer / MonteCarlo.jl

Classical and quantum Monte Carlo simulations in Julia
https://carstenbauer.github.io/MonteCarlo.jl/dev/
Other
186 stars 18 forks source link

fix variable order in propose_local/accept_local #59

Closed ffreyer closed 4 years ago

ffreyer commented 4 years ago

Currently we have

https://github.com/crstnbr/MonteCarlo.jl/blob/1c931b57588f44a2ddfe3b547e01aae3332fc221/src/flavors/MC/MC.jl#L224

https://github.com/crstnbr/MonteCarlo.jl/blob/1c931b57588f44a2ddfe3b547e01aae3332fc221/src/flavors/MC/MC.jl#L228

i.e. ΔE, Δsite swaps to Δsite, ΔE when given to accept_local. We should keep the same order.

ffreyer commented 4 years ago

This also applies to DQMC, actually