search

cartalyst / sentinel

A framework agnostic authentication & authorization system.
BSD 3-Clause "New" or "Revised" License
1.51k stars 238 forks source link

fix docblock return value of logout function #478

Closed 8633brown closed 5 years ago

8633brown commented 5 years ago

sentinel returns IlluminateUserRepository::recordLogout in the logout function which can return the user on failure. https://github.com/cartalyst/sentinel/blob/d1e5d6c2afab33134c70eac1962aed769ddc3077/src/Users/UserRepositoryInterface.php#L59-L65

brunogaspar commented 5 years ago

hmm i guess it's preferable to keep it consistent and just return true after the recordLogout call.

I think i had it like that before merging 2.0 into master earlier today and dealing with the merge conflicts changed that line back.

It also ensures that the return type is correct.

brunogaspar commented 5 years ago

Fixed on https://github.com/cartalyst/sentinel/commit/ae54b87930bce90a197367492060f199b920e3d4