search

cartalyst / sentinel

A framework agnostic authentication & authorization system.
BSD 3-Clause "New" or "Revised" License
1.52k stars 240 forks source link

[proposal] restructure tests #484

Closed 8633brown closed 5 years ago

8633brown commented 5 years ago

tests/Throttling/ThrottleCheckpointTest.php should become test/Checkpoints/ThrottleCkeckpointTest.php as it does not test throttling it tests checkpoints.

tests/Checkpoints/CheckpointsTest.php should be merged into tests/SentinelTest.php as it doesnt test checkpoints it tests sentinel calls the relevant checkpoints which is mostly covered in SentinelTest.php

also could the PermissibleTrait class be modified to use a class instead of a string for the permissableClass instance. it would make testing easier for users and roles. and to me it makes sense to typehint PermissibleTrait::setPermissionsClass for PermissionsInterface instead of a string. forget this not the right thing to do.

brunogaspar commented 5 years ago

Seems you've submitted a pull request :)