better use of test setUp methods

cartalyst / sentinel

A framework agnostic authentication & authorization system.

BSD 3-Clause "New" or "Revised" License

1.51k stars 238 forks source link

better use of test setUp methods #497

Closed 8633brown closed 5 years ago

8633brown commented 5 years ago

moved most mock and object creations to TestCase::setUp to hopefully improve readabliity for some tests. shouldReceiveExpires methods used for building query mock have been removed for better consistency. for example see IlluminateActivationRepository.

8633brown commented 5 years ago

Fails because of c78574df37c5f87d9f3324db76f9552ea6bd0721 needs the $user variable changed to $this->user I'll try and get to it today.

Edit: I might be wrong. Either way I'll still try and get this sorted today.

suwardany commented 5 years ago

yep, were those @8633brown .. i've tackled it .. thanks!