fix: Add missing argument type declarations

cartalyst / sentinel

A framework agnostic authentication & authorization system.

BSD 3-Clause "New" or "Revised" License

1.51k stars 238 forks source link

Closed cbj4074 closed 4 years ago

cbj4074 commented 4 years ago

Exceptions are thrown absent these declarations (i.e., this is not merely a style/syntax change).

brunogaspar commented 4 years ago

Probably needs to be sent to the 3.0 branch.

We can change the base branch, so probably no need to send a new PR.

brunogaspar commented 4 years ago

Thanks for the fix @cbj4074 !

cbj4074 commented 4 years ago

You're very welcome @brunogaspar !

Any chance we can get a bug-fix tag on this? The issue throws an exception (at least in PHP 7.3.9), so it's a show-stopper.

suwardany commented 4 years ago

will do today @cbj4074

suwardany commented 4 years ago

v3.0.1 released @cbj4074