cartant / firebase-nightlight

An in-memory, JavaScript mock for the Firebase Web API
https://cartant.github.io/firebase-nightlight/
Other
37 stars 8 forks source link

Fix: Added firebase-interfaces to the dist:copy command #53

Closed jairmilanes closed 5 years ago

jairmilanes commented 5 years ago

Hey, first of all thanks for creating this, I had started creating my own mocks and you saved me a ton of time.

While using Mock, Jest was complaining that it could not find the firebase definitions, investigating I noticed that the firebase-interfaces was missing from dist, since it will not be processed by the tsc compiler (it's a js file), I added it to the dist:copy script to include it in the builds like Lodash currently is.

Hope it can be reviewed, published soon!

cartant commented 5 years ago

Awesome. Thanks for the PR.