cartant / rxjs-marbles

An RxJS marble testing library for any test framework
https://cartant.github.io/rxjs-marbles/
MIT License
300 stars 18 forks source link

jasmine: preserve 'this' test context #36

Closed Telem closed 6 years ago

Telem commented 6 years ago

This PR allows the "this" context provided by jasmine to be preserved within marbles() wrapped test functions.

cartant commented 6 years ago

Thanks. LGTM. Can you rebase using master, please? I see you've done just that. Thanks.

cartant commented 6 years ago

I've just published 3.0.1. Thanks again for your contribution.

BTW, do you need your change to be backported so that it can be used with the version of rxjs-marbles that uses RxJS v5?

Telem commented 6 years ago

Brilliant, thanks a lot !

I will be alright with RxJS 6, I'm about to upgrade to Angular 6 which depends on it anyway.

cartant commented 6 years ago

No worries.