Filter input doesn't act like a search input

carteb / carte-blanche

An isolated development space with integrated fuzz testing for your components. See them individually, explore them in different states and quickly and confidently develop them.

https://www.youtube.com/watch?v=6g3-TQ6aaw8

MIT License

1.5k stars 46 forks source link

Filter input doesn't act like a search input #195

Closed okonet closed 8 years ago

okonet commented 8 years ago

Focus "filter" input and start typing to filter components
Press ESC to clear the search (default <input type="search" /> behavior)

See how sidebar is hidden instead of resetting input value.

Also, it would be great to have the standard appearance with "reset" button (×) on the right side for this input to keep the affordance.

nikgraf commented 8 years ago

sounds good, wanna take it @okonet?

okonet commented 8 years ago

I could try. It might conflict with #185 though.

mxstbr commented 8 years ago

It shouldn't if you do evt.stopPropagation()!

okonet commented 8 years ago

Since this is the built in feature, I'd opt-in for filtering the event handling out from the custom handler #185 has introduced as re-implementing this behavior on my own for the input.

nikgraf commented 8 years ago

👍