search

carteb / carte-blanche

An isolated development space with integrated fuzz testing for your components. See them individually, explore them in different states and quickly and confidently develop them.
https://www.youtube.com/watch?v=6g3-TQ6aaw8
MIT License
1.5k stars 47 forks source link

Make React a peer dependency #268

Closed wmertens closed 8 years ago

wmertens commented 8 years ago

This project fails if the React is not v15+, and you can't have your own version of React because webpack will bundle the one from the project that uses Carte Blanche.

nikgraf commented 8 years ago

I will close this as peerDepedencies are npm2 and we want to move forward. Let's define engine npm3 and only focus on this. see https://codingwithspike.wordpress.com/2016/01/21/dealing-with-the-deprecation-of-peerdependencies-in-npm-3/

wmertens commented 8 years ago

Err, that doesn't actually solve the problem, you still need to declare React 15+ as your peer dependency because Carte Blanche doesn't work with 0.14 and there can only be one React in the project, so the project needs to use React 15+ too…

nikgraf commented 8 years ago

How would the peer dependency help here especially with npm3?

wmertens commented 8 years ago

It would tell the dev that is installing carte-blanche if their version of React is wrong. They would get an invalid peer dep error.

On Mon, Jun 27, 2016 at 12:11 AM Nik Graf notifications@github.com wrote:

How would the peer dependency help here especially with npm3?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/carteb/carte-blanche/pull/268#issuecomment-228626103, or mute the thread https://github.com/notifications/unsubscribe/AADWlvdNXlLDIgQ39HypYGHEhIcATYRLks5qPvkEgaJpZM4IsrwC .

Wout. (typed on mobile, excuse terseness)

nikgraf commented 8 years ago

@wmertens I'm pretty sure in npm3 you get an invalid dep error as it flattens out them. Is this not correct?