search

carteb / carte-blanche

An isolated development space with integrated fuzz testing for your components. See them individually, explore them in different states and quickly and confidently develop them.
https://www.youtube.com/watch?v=6g3-TQ6aaw8
MIT License
1.5k stars 47 forks source link

React-Plugin port parse validation #281

Closed johann-sonntagbauer closed 8 years ago

johann-sonntagbauer commented 8 years ago

When setting a port on the React-Plugin the validation mechanism only accepts NaNs :smile: 

C:\Projects\client-core\node_modules\carte-blanche-react-plugin\dist\plugin.js:29
    throw new Error('The "port" option of the ReactPlugin must be a number!\n\n');
    ^

Error: The "port" option of the ReactPlugin must be a number!
  if (this.options.port && !isNaN(parsedPort)) {
    throw new Error('The "port" option of the ReactPlugin must be a number!\n\n');
  }
mxstbr commented 8 years ago

Fixed in #282, thanks!