carteb / carte-blanche

An isolated development space with integrated fuzz testing for your components. See them individually, explore them in different states and quickly and confidently develop them.
https://www.youtube.com/watch?v=6g3-TQ6aaw8
MIT License
1.5k stars 47 forks source link

CommonsChunkPlugin support #328

Closed mxstbr closed 8 years ago

mxstbr commented 8 years ago

This PR adds implicit (!) CommonsChunkPlugin support and an example with the plugin enabled.

That means we auto-detect if users use it and adapt to it by including the common chunk into our HTML files. No config needed™!

:tada:

Note: We check if users have it included by checking the constructor name in the plugins array. This means if people do something weird like import CommonsChunkPlugin as SomethingElse and then do new SomethingElse() in their plugins array, it won't work, but honestly we should discourage that anyway.

Two small points-of-action we should do after this is merged:

nikgraf commented 8 years ago

booom 🎉 looks good to me