search

carteb / carte-blanche

An isolated development space with integrated fuzz testing for your components. See them individually, explore them in different states and quickly and confidently develop them.
https://www.youtube.com/watch?v=6g3-TQ6aaw8
MIT License
1.5k stars 47 forks source link

Split client into client and iframe client #329

Closed nikgraf closed 8 years ago

nikgraf commented 8 years ago

Until now we both parts where part of the client and just determined on a condition.

The idea here is for once to have cleaner setup, but also to improve the execution time. Unfortunately this will bring just save us around 50 milliseconds per iFrame (on my machine).

Previous loading results with client & iframe client combined:

screen shot 2016-06-12 at 08 12 38

Loading results with client & iframe client being separate:

screen shot 2016-06-12 at 08 10 37

The big chunk definitely is the user-bundle with the app inside taking up around 700milliseconds to evaluate:

screen shot 2016-06-12 at 08 07 15

Even in our dev example the file-size of the user-bundle is already quite large with 9.6 MB

user-bundle

mxstbr commented 8 years ago

Holy hell what is in that user-bundle?

nikgraf commented 8 years ago

@mxstbr all the webpack, hot-reloading, all libraries, the app, inline source maps (all uncompressed)

mxstbr commented 8 years ago

all uncompressed

That sounds like something we can change?

nikgraf commented 8 years ago

@mxstbr yeah, that might help a bit on the other hand it will slow down recompiling with hot reloading afaik - will need some perf testing