carteb / carte-blanche

An isolated development space with integrated fuzz testing for your components. See them individually, explore them in different states and quickly and confidently develop them.
https://www.youtube.com/watch?v=6g3-TQ6aaw8
MIT License
1.5k stars 47 forks source link

use source of faker instead of compiled one #339

Closed FezVrasta closed 8 years ago

FezVrasta commented 8 years ago

fixes #336

I haven't noticed any problem with my edits, the data is correctly randomized.

Tests fail with:

1) codeToCustomMetadata should catch errors correctly:

      AssertionError: expected { Object (err) } to deeply equal { Object (err) }
      + expected - actual

       {
      -  "err": "SyntaxError: Unexpected token u in JSON at position 26"
      +  "err": "SyntaxError: Unexpected token u"
       }

      at Assertion.assertEqual (plugins/react/node_modules/chai/lib/chai/core/assertions.js:485:19)
      at Assertion.ctx.(anonymous function) [as equal] (plugins/react/node_modules/chai/lib/chai/utils/addMethod.js:41:25)
      at Context.<anonymous> (codeToCustomMetadata.js:34:48)

But it fails even on master, so I don't think it's related to this PR

mxstbr commented 8 years ago

LGTM, @nikgraf?

nikgraf commented 8 years ago

nice, looks good