carteb / carte-blanche

An isolated development space with integrated fuzz testing for your components. See them individually, explore them in different states and quickly and confidently develop them.
https://www.youtube.com/watch?v=6g3-TQ6aaw8
MIT License
1.5k stars 46 forks source link

webpack 2.1.0-beta.14 Uncaught Exception #363

Closed ChristopherBiscardi closed 8 years ago

ChristopherBiscardi commented 8 years ago

webpack 2.1.0-beta.14 will throw the following error.

CarteBlanche started at /carte-blanche
Uncaught Exception...
TypeError: d.getWarnings is not a function
    at <project>/node_modules/webpack/lib/Compilation.js:594:21
    at Array.forEach (native)
    at <project>/node_modules/webpack/lib/Compilation.js:593:22
    at Array.forEach (native)
    at Compilation.reportDependencyWarnings (<project>/node_modules/webpack/lib/Compilation.js:592:9)
    at Compilation.<anonymous> (<project>/node_modules/webpack/lib/Compilation.js:483:8)
    at Array.forEach (native)
    at Compilation.seal (<project>/node_modules/webpack/lib/Compilation.js:482:15)
    at Compiler.<anonymous> (<project>/node_modules/webpack/lib/Compiler.js:431:15)
    at <project>/node_modules/webpack/node_modules/tapable/lib/Tapable.js:152:11
    at Compilation.<anonymous> (<project>/node_modules/webpack/lib/Compilation.js:430:10)
    at <project>/node_modules/webpack/lib/Compilation.js:405:12
    at <project>/node_modules/webpack/lib/Compilation.js:320:10
    at <project>/node_modules/async/lib/async.js:52:16
    at done (<project>/node_modules/async/lib/async.js:246:17)
    at <project>/node_modules/async/lib/async.js:44:16
Uncaught Exception...
undefined

I didn't have time to look into why this is happening, but I've narrowed it down to being in the .14 release.

Temporary Fix

downgrade to webpack 2.1.0-beta.13

nikgraf commented 8 years ago

I briefly looked into the issue. getWarnings seems be new and causing the issue https://github.com/webpack/webpack/compare/36e4fd2...6748dca#diff-d6308b00976bdf2edefc0f08dd6e1cafR594

nikgraf commented 8 years ago

@sokra did we do something wrong in Carte Blanche or is a bug of the Beta?

nikgraf commented 8 years ago

Working on this. We identified the ExtraEntryPlugin as root cause although I'm not sure if it's a bug in webpack or we do something wrong in the ExtraEntryPlugin: https://github.com/carteb/carte-blanche/pull/379

sokra commented 8 years ago

Looks like the extra-entry-plugin should have a peerDependency to webpack instead of a depenency. And webpack@^2.1.0-beta need to be included.

https://github.com/jantimon/extra-entry-webpack-plugin/blob/master/package.json#L46

nikgraf commented 8 years ago

This will be resolved with the next release 😄 https://github.com/carteb/carte-blanche/pull/379

ChristopherBiscardi commented 8 years ago

👍