Closed adamperkowski closed 2 days ago
Thank you, again!
I didn't realize the latest commit wasn't compiling, thanks for catching that. I have a bunch of changes uncommitted on my machine still, which does build, though, so I'll cherry pick from your PR and push those directly into master
(remember to co-author) (jk, not that important. but still)
fixed with 29e6e75dbd6ec43504cce6f184d93e3bf539cb8c
(added you as co-author :))
You know you can close issues and PRs by putting the closing keywords in a commit's description?
Example: https://github.com/adamperkowski/nvrs/commit/8322adaac003dd9210bd291399b275eb5daaf673 https://github.com/adamperkowski/nvrs/issues/2
had no idea, thanks for the tip!
I didn't realize the latest commit wasn't compiling, thanks for catching that. I have a bunch of changes uncommitted on my machine still, which does build, though, so I'll cherry pick from your PR and push those directly into master