search

cartesi / dave

Cartesi fraud-proof system
Apache License 2.0
13 stars 11 forks source link

docs: add readme #6

Closed GCdePaula closed 6 months ago

claudioantonio commented 6 months ago

It is good to me, after considering Guilherme's suggestions. 😍

GCdePaula commented 6 months ago

Can you try to follow the instructions to run the node?

@claudioantonio @guidanoli @miltonjonat

miltonjonat commented 6 months ago

Can you try to follow the instructions to run the node?

@claudioantonio @guidanoli @miltonjonat

Didn't work for me:

 => [ 9/15] ADD ./permissionless-arbitration/contracts/src/ ./src/                                                                                                                                                  0.1s
 => [10/15] RUN forge --version                                                                                                                                                                                     0.3s
 => ERROR [11/15] RUN forge build                                                                                                                                                                                   0.5s
------
 > [11/15] RUN forge build:
0.498 Error: 
0.498 failed to resolve file: "/app/contracts/../../machine-emulator-sdk/solidity-step/ready_src/UArchStep.sol": No such file or directory (os error 2); check configured remappings.
0.498     --> "/app/contracts/src/tournament/abstracts/LeafTournament.sol"
0.498         "step/ready_src/UArchStep.sol"
miltonjonat commented 6 months ago

Ok, now it worked! I needed to download a bunch of submodules - and that's not on the README.

git submodule update --init --recursive

(I admit I don't like submodules very much, but that's a personal thing)

guidanoli commented 6 months ago

I had to run the command thrice, because some downloads would fail (but that's probably my internet's fault?). Also, I had to run git submodule update --init --recursive. This command should be on the Lua node README.

GCdePaula commented 6 months ago

Nice catches! I've updated with the requests. @claudioantonio can you take a look?

claudioantonio commented 6 months ago

It worked beautifully @GCdePaula ! ❤️ I only missed a brief description of what is the example, what I executed. 😉

miltonjonat commented 6 months ago

Yeah a quick description of what is executed would be cool, I was a bit lost too!

guidanoli commented 6 months ago

I agree. I had no idea what was being printed to me, as a newcomer.

GCdePaula commented 6 months ago

I've added more info to the readme!

I think we can improve the logging itself later in a different PR. It's good for debugging, but as a prototype showing newcomers what's going on, it may be improved.

Let me know if there's more improvements to the readme.

augustoteixeira commented 6 months ago

This is looking great!