cartesi / explorer

Cartesi Blockchain Explorer
https://explorer.cartesi.io
Apache License 2.0
9 stars 12 forks source link

Remove code related to the gas based staking pools #144

Closed dandheedge closed 1 year ago

dandheedge commented 1 year ago

Fixes #143

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 6:32am
github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 6940132476


Totals Coverage Status
Change from base Build 6737463225: 4.6%
Covered Lines: 338
Relevant Lines: 401

💛 - Coveralls
brunomenezes commented 1 year ago

LGTM! I just noticed a couple of messages that we may also want to remove:

  • /staking/src/utils/labels.ts - gasTaxCommission
  • /staking/src/utils/messages.ts - messages.commission.model.gasBased

Hey @dandheedge, Do you mind removing these as well before we merge?

brunomenezes commented 1 year ago

LGTM! I just noticed a couple of messages that we may also want to remove:

  • /staking/src/utils/labels.ts - gasTaxCommission
  • /staking/src/utils/messages.ts - messages.commission.model.gasBased

Hey @dandheedge, Do you mind removing these as well before we merge?

Just giving a nudge on that before we merge cc: @dandheedge

dandheedge commented 1 year ago

LGTM! I just noticed a couple of messages that we may also want to remove:

  • /staking/src/utils/labels.ts - gasTaxCommission
  • /staking/src/utils/messages.ts - messages.commission.model.gasBased

Hey @dandheedge, Do you mind removing these as well before we merge?

Just giving a nudge on that before we merge cc: @dandheedge

@brunomenezes @nevendyulgerov already removed it