search

cartesi / explorer

Cartesi Blockchain Explorer
https://explorer.cartesi.io
Apache License 2.0
9 stars 12 forks source link

#156 Disable query polling #157

Closed nevendyulgerov closed 3 months ago

nevendyulgerov commented 4 months ago

Summary

I removed the pollInterval setting for all graphql queries so that we are doing any http requests to the graphql BE only on page load. This can be easily noticed on the /blocks page, where we were previously polling a lot of data every 30 seconds.

I also checked the useBlockNumber custom hook that we have in /staking/src/services/eth.tsx. It is used on most of the pages and although it often causes re-renders in components that use it (because the block number changes every ~15 seconds), I didn't notice it causing any side effects like extra http requests happening. That's why I didn't make any changes in useBlockNumber.

Testing Instructions

  1. Build the app locally for dev env
  2. Go to the / (home), or /blocks , or any other page where we were previously polling the graphql queries
  3. Observe the network requests
  4. Notice that no extra network requests for the page data are being made to the graphql BE after the page load
vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2024 10:59am
coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 10131129284

Details

Totals Coverage Status
Change from base Build 10001733387: 0.0%
Covered Lines: 338
Relevant Lines: 401
💛 - Coveralls