cartesi / explorer

Cartesi Blockchain Explorer
https://explorer.cartesi.io
Apache License 2.0
9 stars 12 forks source link

#37 Update storybook dependencies #38

Closed nevendyulgerov closed 1 year ago

nevendyulgerov commented 1 year ago

Update storybook packages to latest compatible version - 6.5.14 (one of their latest 6.x versions). Before opting for that version, I spent a day exploring their latest version which is 7.0.x.

In it, there are significant architectural changes to storybook. Their team has introduced the concept of frameworks, so it's up to users to determine the correct framework for their use case.

I tried their migration tools but those suggested @storybook/nextjs framework which was odd for packages/ui since we do not use nextjs there (we did for the routing but I refactored that before attempting the migration). In any case, I went with what the migration tool suggested but faced issues with webpack 5 IgnorePlugin and also with the css-loader of @storybook/nextjs. Then, I also tried @storybook/react-webpack5 but that didn't work either due to issues with ts transformers. I think some of those issues are due to still poor monorepo support from storybook v7 which will probably improve in time.

So, in the end due to the wide array of issues that I faced I decided to wait for them to release at least 7.x.x version before attempting to upgrade to it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2023 9:20pm
staking ❌ Failed (Inspect) Jul 10, 2023 9:20pm
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5486740842


Totals Coverage Status
Change from base Build 5472984306: 0.0%
Covered Lines: 2548
Relevant Lines: 3337

💛 - Coveralls
coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 5486740842

Details


Files with Coverage Reduction New Missed Lines %
apps/rollups/src/services/useRollupsFactory.ts 15 46.34%
<!-- Total: 15 -->
Totals Coverage Status
Change from base Build 5472984306: 0.0%
Covered Lines: 2548
Relevant Lines: 3337

💛 - Coveralls