cartesi / explorer

Cartesi Blockchain Explorer
https://explorer.cartesi.io
Apache License 2.0
9 stars 12 forks source link

#24 Update onboard dependencies and remove duplicates #44

Closed dandheedge closed 1 year ago

dandheedge commented 1 year ago

Update the onboard dependencies on the packages/wallet and remove from apps/staking from the package.json.

Fixes #24 #28

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2023 8:17pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2023 8:17pm
github-actions[bot] commented 1 year ago

Pull Request Test Coverage Report for Build 5676848998


Totals Coverage Status
Change from base Build 5650857639: 0.02%
Covered Lines: 2567
Relevant Lines: 3344

💛 - Coveralls
dandheedge commented 1 year ago

Hi @brunomenezes,

The @web3-onboard/walletconnectpackage is now only support v2 of walletconnect. Where there are some major changes on the setting and UI. The new update that is different from v1 is the projectId that we have to provide it. Right now, I'm using my personal account to get the projectId on WalletConnect and adding it on .env.development and .env.production. Do you think it is the correct solution? Or maybe you can add the new environment on vercel?

Here for further reading on Walletconnect major changes:

brunomenezes commented 1 year ago

@dandheedge, The Vercel build is broken. You probably could replicate that using the build command.

dandheedge commented 1 year ago

@dandheedge, The Vercel build is broken. You probably could replicate that using the build command.

Done

brunomenezes commented 1 year ago

@dandheedge, I am testing the ledger and I will need to push some code.