cartesi / explorer

Cartesi Blockchain Explorer
https://explorer.cartesi.io
Apache License 2.0
9 stars 12 forks source link

Fix: App navigation #50

Closed brunomenezes closed 1 year ago

brunomenezes commented 1 year ago

Summary

A report was made that links in the headers were changing the address bar, but the app would not "display" the page itself. But the reality is that the links and buttons (usually calling the next router programmatically) would also not work. After checking the released tags, the problem was introduced on v3.5.0 after checking the changes between the tags, the cause was an item added in the useEffect watchlist causing an infinite loop in two useEffect hooks inside the ga4Tracker.tsx here and here. The gist is that the main-thread was flooded with calls and nextJS router system was having a hard time to do its job.

PS: That was flying under the radar because most of the people enter the App with their wallets automatically connected (including us 🫠), causing the useEffect to stop firing events as the analytics would be finally initialised.

Before and After

before-changes

after-changes

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rollups ✅ Ready (Inspect) Visit Preview Jul 17, 2023 1:33pm
staking ✅ Ready (Inspect) Visit Preview Jul 17, 2023 1:33pm
coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5576322396


Totals Coverage Status
Change from base Build 5526535182: 0.0%
Covered Lines: 2546
Relevant Lines: 3317

💛 - Coveralls