Closed brunomenezes closed 1 year ago
vercel[bot]
commented
1 year ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| rollups | ✅ Ready (Inspect) | Visit Preview | Aug 2, 2023 7:32am | |
| staking | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 2, 2023 7:32am |
github-actions[bot]
commented
1 year ago | Totals | |
|---|---|
| Change from base Build 5730936453: | -0.03% |
| Covered Lines: | 2565 |
| Relevant Lines: | 3342 |
brunomenezes
commented
1 year ago I'll bypass the review, as there are already users being affected.
cc: @tuler , @nevendyulgerov, @dandheedge
Summary
We just released the upgrade of multiple modules from web3-onboard given the emergency to move from WalletConnect v1.0 to v2.0. The Ledger module specifically is not working properly; after its selection and making the connection, a few pieces of information are displayed, but the main driver (ethers web3provider) is not being able to communicate with contracts, nor do a series of other actions making the functionalities from the Staking app unusable. The users can connect the ledger hardware wallet through the WalletConnect option. The new workflow is the same since the new version uses the Ledger Live App.
PS: I flicked a message in the blocknative discord and have a branch here that has modifications and the ledger still available. So depending on how they respond, we may bring it back. In the meantime, I think removing the standalone option is best to avoid confusion.