search

cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups
https://cartesi.github.io/rollups-contracts/
Apache License 2.0
21 stars 39 forks source link

Propagate errors on voucher execution in CartesiDApps #107

Closed xdaniortega closed 11 months ago

xdaniortega commented 1 year ago

This approach does not handle any returned value at executeVoucher function as errors now are bubbled up and not reverting means the execution is always successful.

xdaniortega commented 1 year ago

If you find this approach correct I will catch correctly expected reverts with vm.expectRevert();

guidanoli commented 1 year ago

If you find this approach correct I will catch correctly expected reverts with vm.expectRevert();

Yes, this is the intended approach. :-)

guidanoli commented 11 months ago

Superseded by #135