cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups
https://cartesi.github.io/rollups-contracts/
Apache License 2.0
21 stars 39 forks source link

Remove yarn workspace #119

Closed guidanoli closed 1 year ago

guidanoli commented 1 year ago

We want to use changesets for managing releases, but if @cartesi/rollups is contained inside a yarn workspace, then the tag that changesets would create would be like @cartesi/rollups@1.2.0, while we want it to be v1.2.0. In order to do that, we need to make @cartesi/rollups no longer part of a yarn workspace, but a package of its own. So, this is the first change.

Remove yarn workspace:

Taking advantage of this massive change, I also took the freedom to...

A second change was the removal of publish.yml and addition of release.yml. While publish.yml runs yarn npm directly, release.yml uses changesets/action. This command does two things:

Finally, I needed to move the CHANGELOG.md from the repository root to onchain/rollups, because the changesets action expects this file to be in the package root directory. Later, when rollups-arbitration gets merged into rollups, we'll move everything inside rollups to the repository root, so CHANGELOG.md will come back to the repository root. Also, I filtered the entries from CHANGELOG.md that were not related to @cartesi/rollups (but were related to the node, for example), and formatted it like changesets does it.

changeset-bot[bot] commented 1 year ago

⚠️ No Changeset found

Latest commit: 3b2f201e9cbeb2240d9171957bcffe176403c466

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR