search

cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups
https://cartesi.github.io/rollups-contracts/
Apache License 2.0
21 stars 39 forks source link

fix portal tests address overlaps #124

Closed ZzzzHui closed 12 months ago

ZzzzHui commented 12 months ago

It occurred to me that sometimes github CI tests failed on portal invariant tests like this one. The reason is that we used msg.sender as token sender, and sometimes forge assigns this random msg.sender an address that has already deployed a contract (e.g. the portal). This would cause the invariant test to fail because we require portal to have 0 balance all the time.

changeset-bot[bot] commented 12 months ago

⚠️ No Changeset found

Latest commit: b8b9f7d060c51b2d176dfa36522754c7b72062bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

guidanoli commented 12 months ago

We don't need the no changelog label anymore, as it was only used to check if the CHANGELOG.md file was modified or not. Now, since we are using changesets, this label will soon be removed.