Remove `success` from ERC-20 deposit input

cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups

https://cartesi.github.io/rollups-contracts/

Apache License 2.0

21 stars 39 forks source link

Remove `success` from ERC-20 deposit input #132

Closed guidanoli closed 11 months ago

guidanoli commented 11 months ago

📚 Context

Issue #113 suggests making the ERC-20 portal check if success is true, keeping the input ABI intact. However, the DApp still receives this field and has to check it, even though it is guaranteed to be true at the smart contract level.

✔️ Solution

Remove this value from the ERC-20 deposit input, since it is guaranteed to be true.

📈 Subtasks

[ ] Change the ERC-20 Portal
[ ] Update the tests

ZzzzHui commented 11 months ago

This will wait until PR #136 is merged and branch next is rebased