cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups
https://cartesi.github.io/rollups-contracts/
Apache License 2.0
18 stars 38 forks source link

refactor!: remove unnecessary contracts/deployments #146

Closed guidanoli closed 9 months ago

guidanoli commented 9 months ago

Removing deployment artifacts

I'll share here how I removed specific contracts from the deployment artifacts. Take HistoryFactory as an example.

git ls-files | grep HistoryFactory | xargs git rm
for file in export/abi/*.json
do
  jq 'del(.contracts.HistoryFactory)' "$file" > tmp
  mv tmp "$file"
  git add "$file"
done
guidanoli commented 9 months ago

Don't mind the branch name feature/shared-history. Its meaning has been disassociated from the name, but we'll keep using it anyway.

pedroargento commented 9 months ago

You forgot to delete IHistory.sol.

guidanoli commented 9 months ago

Removing IHistory now would break Authority. We'll remove as soon as Authority no longer depends on it.