cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups
https://cartesi.github.io/rollups-contracts/
Apache License 2.0
18 stars 38 forks source link

Comply with Solidity style guide #164

Closed guidanoli closed 7 months ago

guidanoli commented 9 months ago

📚 Context

Solidity specifies the following style guide. There are some guidelines we don't follow. The most relevant is the naming convention of function parameters, and internal/private functions and state variables.

✔️ Solution

Update contracts to comply with the style guide. We should take the opportunity of v2 to do this refactoring, since all contracts will be redeployed anyway. Also, check if the guidelines can be checked and enforced by prettier.

guidanoli commented 9 months ago

General pipeline

guidanoli commented 9 months ago

Let's leave this to last on the release to avoid PR conflicts.

ZzzzHui commented 8 months ago

For reference,