Closed guidanoli closed 9 months ago
Necessary side effects:
solc
0.8.20
CartesiDApp
Authority
Ownable
ReentrancyGuard
Extra changes:
Address
EtherPortal
EtherTransferFailed
FailedInnerCall
dapp
address payable
IEtherPortal
Closes #161
With the upgrade of Ownable, we should also update comments here and here. Because now instead of 2, now there is only 1 OwnershipTransferred event emitted.
OwnershipTransferred
This branch needs a rebase
Rebased on top of main.
main
Necessary side effects:
solc
to0.8.20
(updated pragma)CartesiDApp
andAuthority
, which inherit fromOwnable
(updated constructor)CartesiDApp
which inherits fromReentrancyGuard
(updated file path)Extra changes:
Address
library inEtherPortal
to send Ether to the DApp contractEtherTransferFailed
custom error, and use OpenZeppelin'sFailedInnerCall
custom error insteaddapp
asaddress payable
onIEtherPortal
(function selector stays the same)Ownable
Closes #161