cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups
https://cartesi.github.io/rollups-contracts/
Apache License 2.0
17 stars 37 forks source link

Merge Cartesi Contracts into Rollux on Syscoin's Tanenbaum Testnet #197

Closed sandhilt closed 2 months ago

sandhilt commented 6 months ago

Overview

This pull request integrates the Cartesi contracts into the Rollux environment, leveraging Syscoin's Tanenbaum testnet. This merge signifies a pivotal step in our ongoing efforts to enhance interoperability and expand the capabilities of our blockchain ecosystem.

Request for Review

I invite team members to review the changes and provide their valuable feedback. Special attention to contract integrations, code compatibility, and performance optimizations would be highly appreciated. Please let me know if need some refinements.

pedroargento commented 6 months ago

I see no problem merging this, but the problem is making it clear what version of rollups-contracts this deployments refer too. Those deployments contain changes that are not yet merged in the code base.

Thoughts, @guidanoli and @tuler?

tuler commented 6 months ago

If it's for rollups V2 I'd wait until the very end of the release processo, when you freeze the code

guidanoli commented 6 months ago

First, thanks for the PR! Second, I agree with @tuler in that it would be safer if we synced the deployment process with the rest of the networks we currently support. Traditionally, this happens after we "freeze" the contracts (i.e. no changes are made to them until the next release cycle starts).

guidanoli commented 5 months ago

Just a heads-up: we moved everything inside onchain/rollups to the repository root. :-)

guidanoli commented 3 months ago

@sandhilt @fabiooshiro Does this still make sense for v2? Are you still working on the integration with Syscoin?

fabiooshiro commented 3 months ago

Our main focus is to provide a convenience layer to v2, so the Syscoin integration needs to align with this version. We'll likely need to do the Syscoin integration after this update.