cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups
https://cartesi.github.io/rollups-contracts/
Apache License 2.0
17 stars 37 forks source link

Adjust nomenclature used in `IInputBox` #203

Closed guidanoli closed 6 months ago

guidanoli commented 6 months ago

📚 Context

On #201, we've made some changes to address #2. Most importantly...

With #84, however, the Server Manager will not write just the payload to the rx buffer, but the whole input (payload and metadata) encoded as a Solidity function call.

✔️ Solution

We need to make the following adjustments to the IInputBox interface...

ZzzzHui commented 6 months ago

Hey Gui. This issue has overlap with the issue https://github.com/cartesi/rollups-contracts/issues/203 and has already been addressed in PR https://github.com/cartesi/rollups-contracts/pull/89, we can either close this issue or link the PR to this too :)

guidanoli commented 6 months ago

This issue has overlap with the issue https://github.com/cartesi/rollups-contracts/issues/203

What do you mean? This is issue #203. :-)

guidanoli commented 6 months ago

we can either close this issue or link the PR to this too :)

Let's link the PR to this issue, then.

ZzzzHui commented 6 months ago

This issue has overlap with the issue #203

What do you mean? This is issue #203. :-)

Sorry for the typo. I meant https://github.com/cartesi/rollups-contracts/issues/84 😂

guidanoli commented 6 months ago

Sorry for the typo. I meant https://github.com/cartesi/rollups-contracts/issues/84 😂

No problem. What is the overlap, though?

ZzzzHui commented 6 months ago

The "blockchain agnostic input" issue involves correctly naming input and payload, which covers this issue.