search

cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups
https://cartesi.github.io/rollups-contracts/
Apache License 2.0
17 stars 37 forks source link

Remove `ApplicationAddressRelay` contract #225

Closed ZzzzHui closed 5 months ago

ZzzzHui commented 6 months ago

📚 Context

After the issue "Include the DApp address in the EvmAdvance input", the contract ApplicationAddressRelay would be of no use. So it should be removed. Also need to update documentation and Mermaid graph.

guidanoli commented 6 months ago

Why is this tagged as "feature"?

ZzzzHui commented 6 months ago

Sorry about that. Now removed.

pedroargento commented 5 months ago

This may affect a lot of DApp developers. Maybe we should wait a version before removing it?

guidanoli commented 5 months ago

The adaptation should be pretty straightforward, I think. Any code that expected inputs from the DAppAddressRelay would have to access the sender metadata field in order to validate the origin of the input. Now, they just need to access the app metadata field from any input.

guidanoli commented 5 months ago

As for HLF developers, they will have to adapt any input processing logic anyway, because of the Input Simplification. The app metadata field will come out from the input blob naturally, if they decode it as a Solidity function call.