chore: adjust changeset files

cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups

https://cartesi.github.io/rollups-contracts/

Apache License 2.0

17 stars 37 forks source link

chore: adjust changeset files #241

Closed guidanoli closed 5 months ago

guidanoli commented 5 months ago

IInputRelay -> IPortal
InputRelay -> Portal
inputRelays -> portals
getInputRelays -> getPortals
DAppAddressRelay was removed, not renamed

guidanoli commented 5 months ago

Still not sure if we should, re-consider using changelog than changeset? Do you think changeset poses more difficulties than bringing convenience?

I think changesets still bring us some benefits:

They avoid conflicts in PRs, by spreading out changes across multiple files
They simplify the process of versioning packages and publishing releases and pre-releases, through a handy-dandy combo of CLI tool + GitHub Action

guidanoli commented 5 months ago

The necessity of keeping changes up-to-date exists with or without changesets. The difference is that changes are spread out across multiple files, so you may need to do full-text search (git grep works wonders).