Refactor tests - Githubissues

cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups

https://cartesi.github.io/rollups-contracts/

Apache License 2.0

17 stars 37 forks source link

Refactor tests #248

Closed guidanoli closed 3 months ago

guidanoli commented 4 months ago

not sure why the CI tests failed. All tests passed on my end. So maybe re-run the CI

Yeah, very weird. In the CI run, the error is a panic 0x32 which signals and out-of-bounds access to an array, which is hard to debug on its own... So, I took a look around Application.t.sol for array accesses, and I think it could have come from _getOutput, so I added a check there, which raises an OutputNotFound custom error instead of panicking.

guidanoli commented 4 months ago

Oops, accidentally re-added _mockConsensus and _calculateEpochHash. Removed them once again.

ZzzzHui commented 4 months ago

Hmmm. Still same error

guidanoli commented 4 months ago

Hmmm. Still same error

Yep, I think I managed to pinpoint the error.

guidanoli commented 4 months ago

Now everything is fixed.

guidanoli commented 4 months ago

Test executing voucher for payable functions
Test validating new type of output (new function selector)
Test executing empty output reverts
Test executing notice reverts
Test executing new type of output reverts

guidanoli commented 3 months ago

Adjusted portal integration tests to expect addInput calls and not use holder contracts, since token transfers work perfectly well with EOA recipients.
Fix vm.expectEmit missing emitter address