search

cartesi / rollups-contracts

Smart Contracts for Cartesi Rollups
https://cartesi.github.io/rollups-contracts/
Apache License 2.0
17 stars 37 forks source link

Deploy to base network #263

Closed tuler closed 2 months ago

tuler commented 3 months ago

I deployed all contracts to base. They are also verified at https://basescan.org

The base branch of this PR is release/1.2.x, but I guess a correct one should be release/1.3.x. Not sure what is your process to do that. I also did not add a changeset or changed any versioning file yet.

tuler commented 3 months ago

Not sure why test broke. Do you have any idea?

guidanoli commented 2 months ago

It's a problem with proof generation system. We've fixed it on main. Let me fix that real quick on this branch.

tuler commented 2 months ago

How are you handling changesets for a 1.x?

tuler commented 2 months ago

Changed base branch to release/1.3.x

guidanoli commented 2 months ago

How are you handling changesets for a 1.x?

There are CI jobs ready to trigger for main, release/* and prerelease/* branches. The CHANGELOG file will naturally get out-of-sync, but GitHub Releases will list all.

tuler commented 2 months ago

What I'm not understanding is that the release/1.x branches do not have changesets installed or the .changeset folder.

guidanoli commented 2 months ago

From what I've checked, release/1.1.x doesn't have changesets, but release/1.2.x (and now, release/1.3.x) do. You can find the .changesets folder at onchain/rollups. These also have the CI set up for releasing packages with changesets.