ENS libs for delegatecall vouchers

[ZzzzHui]

If we decide to take the "all-in-one" approach, I think we could think of a better name for the contract, since we're not really calling addresses by their ENS names in all the cases.

How about CallWithENS?

[guidanoli]

How about CallWithENS?

This name seems more general than what the contract is actually doing. It currently does:

• arbitrary message calls to an address by its ENS name, which covers Ether transfers to ENS-identified users
• ERC-20, ERC-721, and ERC-1155 token transfers to ENS-identified users

So, we are mostly using this contract for asset transfers. Maybe AssetTransferToENS? This wouldn't be 100% accurate for the case of arbitrary message calls, but we could add a note there saying that this entry point can actually be used for more general use cases other than Ether withdrawals, and we're left with a more understandable name for 99% of use cases.

[guidanoli]

This needs a rebase.

[ZzzzHui]

rebased. Also moved internal functions to the end.

[ZzzzHui]

Since we're allowing sendEtherToENS to receive a payload, I think it would be good to have a test where the ENS node actually resolves to the address of a contract, and the payload encodes a function call. We could even recycle part of the "Ether mint" test case for that purpose.

agree

[ZzzzHui]

I've just noticed we're missing the deployment script of SafeERC20Transfer and AssetTransferToENS. They could be deployed by a deploy/03_delegatecall.ts script.

Yeah. But since SafeERC20Transfer is not relevant with this PR, the deploy script will be done in another PR. Ok? :)

[ZzzzHui]

Thank you very much Gui !!!

[ZzzzHui]

Needs @pedroargento 's approval to merge :)

[ZzzzHui]

Thanks very much Pedro :)