`CARTESI_FEATURE_DISABLE_CLAIMER` is a bad name

cartesi / rollups-node

Reference implementation of the Cartesi Rollups Node

Apache License 2.0

20 stars 61 forks source link

`CARTESI_FEATURE_DISABLE_CLAIMER` is a bad name #426

Open renan061 opened 1 month ago

renan061 commented 1 month ago

📚 Context

CARTESI_FEATURE_DISABLE_CLAIMER is somewhat of a bad name. Specially taken into consideration the EXPERIMENTAL_SUNODO variables.

✔️ Solution

We should either rename the variable or clarify in the configuration documentation that it serves as to enable a reader-only mode.

📈 Subtasks

[ ] Evaluate whether we could either merge the CLAIMER and SUNODO_VALIDATOR together or better clarify their usade
[ ] Implement changes
[ ] Update docs

renan061 commented 1 month ago

@endersonmaia 's suggestion that I agree with:

I don't remember where/when, but I did suggest about normalizing the names to bool _DISABLED and _ENABLED suffixes to imply state instead of ENABLE and DISABLE implying action. We use both and it may confuse.

CARTESIFEATUREDISABLE_CLAIMER CARTESI_EXPERIMENTAL_SUNODOVALIDATORENABLED

marcelstanley commented 1 month ago

@endersonmaia 's suggestion that I agree with:

I don't remember where/when, but I did suggest about normalizing the names to bool _DISABLED and _ENABLED suffixes to imply state instead of ENABLE and DISABLE implying action. We use both and it may confuse. CARTESIFEATUREDISABLE_CLAIMER CARTESI_EXPERIMENTAL_SUNODOVALIDATORENABLED

Created #427 to focus on the normalization