search

cartesi / rollups

Cartesi Rollups
30 stars 12 forks source link

Remove `ConsensusCreated` event #156

Closed guidanoli closed 1 year ago

guidanoli commented 1 year ago

Closes #155

tuler commented 1 year ago

So the only reason the InputBox was wired to the Authority was the event? Is there any onchain link left between Authority, History and InputBox?

guidanoli commented 1 year ago

So the only reason the InputBox was wired to the Authority was the event?

Yes.

Is there any onchain link left between Authority, History and InputBox?

With this PR, there will only be a unidirectional link between Authority and History. The History contract can be owned by any address, really. For example, it can be used by other types of consensuses.

pedroargento commented 1 year ago

We need to adjust the factories to remove InputBox as a constructor parameter.

guidanoli commented 1 year ago

We need to adjust the factories to remove InputBox as a constructor parameter.

Yes, this is foreseen by #155. Once this PR is merged, we'll need to do rebase on these branches. :-)

guidanoli commented 1 year ago

Rebased and removed line 20 in Authority.sol (thanks, @ZzzzHui!).