search

cartesi / rollups

Cartesi Rollups
30 stars 12 forks source link

Rename output validity proof #162

Closed xdaniortega closed 1 year ago

xdaniortega commented 1 year ago

Oh! Seems there's been some issue with the variable, it's a typo. Updating it now. Could you please have a look also at discord? @ZzzzHui

xdaniortega commented 1 year ago

After closing this issue we should rename inboxInputIndex, as we discussed in the previous meeting. But this will be addressed in a different PR.

guidanoli commented 1 year ago

I'm ok with the changes, but the commit history and messages can be improved on.

I would squash all the renaming in a single commit with the following message:

refactor(contracts): rename struct fields

* inputIndex --> inputIndexWithinEpoch
* outputIndex --> outputIndexWithinInput
* keccakInHashesSiblings --> outputHashInOutputHashesSiblings

And then, another commit for bumping the grpc-interfaces.

chore(contracts): bump `grpc-interfaces`

* `grpc-interfaces` v0.12.0 --> v0.13.0

See also the 50/72 rule.

xdaniortega commented 1 year ago

@guidanoli Thanks for the feedback, with these improvements we'll have more readable commit messages. Didn't know about the 50/70 rule.