cartesi / rollups

Cartesi Rollups
30 stars 12 forks source link

Add Rust Clippy to CI #25

Closed gligneul closed 1 year ago

gligneul commented 1 year ago

📚 Context

Clippy is a linter for Rust. We can use it to improve our code quality.

✔️ Solution

First, we need to define a sensible configuration for Clippy. We probably can ignore some warnings that don't apply to our code. On the other hand, all warnings that we want to enforce should be considered errors.

Then, we need to fix the existing errors so we can create a new CI workflow that runs Clippy every time. We should evaluate whether it is best to create a new workflow or add Clippy to an existing one.

📈 Subtasks

marcelstanley commented 1 year ago

Raw report from Clippy: 20230706_clippy_report.txt

gligneul commented 1 year ago

I did a quick look, and the warnings make sense. We should fix them.

marcelstanley commented 1 year ago

Some warnings were deferred to cartesi/rollups-node#37

marcelstanley commented 1 year ago

Merged to branch next