cartesi / rollups

Cartesi Rollups
30 stars 12 forks source link

Introducing Custom Errors in Solidity Contracts #49

Closed xdaniortega closed 1 year ago

xdaniortega commented 1 year ago

Description

This pull request introduces custom errors (CE) in our Solidity smart contracts.

Changes introduced

We have to still discuss if we find necessary to change the CE imports in test files as some might get lengthy and also define CE in interfaces, suggested by @guidanoli .

Please review this pull request. Thank you!

xdaniortega commented 1 year ago

Also, we can follow some other improvements for comments and imports here. As the main feature of this branch is complete.

ZzzzHui commented 1 year ago

Hey Daniel. This PR should be rebased

xdaniortega commented 1 year ago

Rebased on top of main.

guidanoli commented 1 year ago

Friendly reminder to use the contracts scope to conform with our flavor of conventional commits.

Example: docs(rollups): [...] ➡️ docs(contracts): [...]

xdaniortega commented 1 year ago

Changed scope of commit messages in favor of conventional commit.

ZzzzHui commented 1 year ago

This PR needs another rebase :)