Closed xdaniortega closed 1 year ago
Also, we can follow some other improvements for comments and imports here. As the main feature of this branch is complete.
Hey Daniel. This PR should be rebased
Rebased on top of main.
Friendly reminder to use the contracts
scope to conform with our flavor of conventional commits.
Example: docs(rollups): [...]
➡️ docs(contracts): [...]
Changed scope of commit messages in favor of conventional commit.
This PR needs another rebase :)
Description
This pull request introduces custom errors (CE) in our Solidity smart contracts.
Changes introduced
revert
andrequire
previous scenarios in favor of CE.testRevertsWithdrawEther
that does one more check for CartesiDApp.testMigrateHistory
in Authority test file.We have to still discuss if we find necessary to change the CE imports in test files as some might get lengthy and also define CE in interfaces, suggested by @guidanoli .
Please review this pull request. Thank you!