search

cartodb-org / cartodb

Location Intelligence & Data Visualization tool
http://cartodb.com
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

[Filters] Sort order dropdown appearing before filter added #188

Closed alissarose closed 6 years ago

alissarose commented 7 years ago

context

In the multi-field select filter (records 210+) a user is prompted to sort the order of results before the filter has been applied. The client does not want this option to appear until the filter has been added since there are datasets that are not displayed due to # of records

approach

Remove the default order option from appearing when records >210; re-render can present difficulties

coyle5280 commented 7 years ago

@alissarose If a user removes all items from the section filter (remote filter with over 220+ options) and they had set a sort of a to z. If they remove all items and the sort disappears should it reset back to default order or should it stay at a to z when it reappears (when they select an item)?

gfiorav commented 7 years ago

It looks like the PR for this issue hasn't been referenced here (nor this issue from the PR) since I don't see and linking messages. Could you link it, @coyle5280 ?

alissarose commented 7 years ago

I think I connected it - https://github.com/cartodb-org/cartodb/pull/201

cc/ @gfiorav

gfiorav commented 7 years ago

That one says #190, not #188 🙈

alissarose commented 7 years ago

yeah, but i think it's the right one?

the PR for #190 is https://github.com/cartodb-org/cartodb/pull/195