search

cartographer-project / cartographer

Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.
Apache License 2.0
7.15k stars 2.25k forks source link

Upgrade Protobuf to v3.13.0 #1746

Closed Yannic closed 4 years ago

Yannic commented 4 years ago

This makes cartographer compatible with --incompatible_blacklisted_protos_requires_proto_info. See bazelbuild/bazel#11694

Signed-off-by: Yannic Bonenberger contact@yannic-bonenberger.com

Yannic commented 4 years ago

The Bazel tests pass: https://buildkite.com/bazel/cartographer/builds/2257

wohe commented 4 years ago

Thanks for the contribution! Could you please sign off the commit, see https://github.com/cartographer-project/cartographer/blob/master/CONTRIBUTING.md? Thanks!

MichaelGrupp commented 4 years ago

@wohe it's already signed

Yannic commented 4 years ago

@wohe The commit is already signed (but the signature wasn't in the PR description)