search

cartographer-project / cartographer

Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.
Apache License 2.0
7.03k stars 2.24k forks source link

Move to GitHub Actions for CI. #1884

Closed wohe closed 2 years ago

wohe commented 2 years ago

This moves away from travis-ci.org which no longer works.

Signed-off-by: Wolfgang Hess whess@fsfe.org

wohe commented 2 years ago

@bochen87 @zjwoody @MichaelGrupp I looked into moving from travis-ci.org to travis-ci.com as Travis suggests, but after doing this work, it only led to an error: "Owner cartographer-project is not on a new pricing." (see https://app.travis-ci.com/github/cartographer-project/cartographer/requests). So I decided to instead move to GitHub Actions which seems to work. Thoughts?

wohe commented 2 years ago

You can see it running here: https://github.com/wohe/cartographer/actions

zjwoody commented 2 years ago

@bochen87 @zjwoody @MichaelGrupp I looked into moving from travis-ci.org to travis-ci.com as Travis suggests, but after doing this work, it only led to an error: "Owner cartographer-project is not on a new pricing." (see https://app.travis-ci.com/github/cartographer-project/cartographer/requests). So I decided to instead move to GitHub Actions which seems to work. Thoughts?

SGTM. Thanks for the work! I searched about the "not on a new pricing" issue: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing It affects the user who build on mac or have more than 5 concurrent builds. IIRC cartographer doesn't support mac, is it because cartographer has more than 5 concurrent builds? Is the concurrent builds caused by the too many pending prs?

wohe commented 2 years ago

@zjwoody There are two more sections about affected users. I think we are "Building on a public repositories only", for which they say:

We will be offering an allotment of OSS minutes that will be reviewed and allocated on a case by case basis. Should you want to apply for these credits please open a request with Travis CI support stating that you’d like to be considered for the OSS allotment.

This is not something I have the time to pursue, hence the change.

Unless someone disagrees I will merge this PR next week. @bochen87 @MichaelGrupp FYI: @georgflick