search

cartographer-project / cartographer

Cartographer is a system that provides real-time simultaneous localization and mapping (SLAM) in 2D and 3D across multiple platforms and sensor configurations.
Apache License 2.0
7.15k stars 2.25k forks source link

Rename transformations. #940

Open pifon2a opened 6 years ago

pifon2a commented 6 years ago

Current transforms have naming which is quite difficult to read when several transforms are chained, e.g.: global_pose * landmark_to_tracking.

As @SirVer suggested, it would be better to have names like: global_from_tracking, tracking_from_landmark.

gaschler commented 6 years ago

Sounds good to me, but changing this in the entire code base would (in my eyes) require an RFC and is so much work I'm not sure if it's worth the effort.

pifon2a commented 6 years ago

A couple of sed commands :). It should not be that hard with the exception of protos.

ojura commented 6 years ago

+1 for an rfc :)